Validations against using EOF on pre-Osaka EVMs #15905
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that we're still missing validations against combinations like
--experimental-eof-version 1 --evm-version cancun. I thought we had that safeguarded already because soltest does have this check, but apparently not. You'll either run into an ICE, or even worse - no error.No error example
This finishes without errors:
You only get an error if you request bytecode (
Error: Experimental EOF support is only available for via-IR compilation.). And with--via-irthe compiler produces invalid IR.ICE example
This triggers an ICE: