Add symlinks to solc-bin/wasm for releases.#8227
Merged
Conversation
chriseth
approved these changes
Feb 3, 2020
Contributor
chriseth
left a comment
chriseth
left a comment
There was a problem hiding this comment.
This is interesting: We publish the first commit on the release branch instead of publishing the tagged commit. This is a remnant of the time where we did not have github releases. We should change this at some point.
Wanna create an issue for that? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately, I'm not sure there's a good way to actually test this... we might just have to keep in mind having an eye on this for the next release.
I also partially addressed #8127 in a separate commit here, since I was touching the file anyways, but I can move that to a separate PR, if you prefer. We still need to decide how we want to deal with the leading zeros in commit hashes of past releases in any case.