chore: depend on public ethereum_ssz and ethereum_serde_utils crates #1239
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
We had dependency on private fork of
ethereum_ssz
andethereum_serde_utils
.How was it fixed?
Adding
ssz
feature toalloy-primitives
eliminated need for custom version ofethereum_ssz
.The custom function
u256_from_dec_str
fromethereum_serde_utils
that Kolby added wasn't really needed becausealloy-primitives
hasU256::from_str_radix(...)
.In order for everything to work, I also needed to fork @KolbyML 's
ssz_types
repo and make it depend on publicethereum_ssz
andethereum_serde_utils
as well (commit link).This leaves us with only 3 non-public repos:
To-Do