Skip to content

Conversation

morph-dev
Copy link
Collaborator

What was wrong?

We had dependency on private fork of ethereum_ssz and ethereum_serde_utils.

How was it fixed?

  1. Adding ssz feature to alloy-primitives eliminated need for custom version of ethereum_ssz.

  2. The custom function u256_from_dec_str from ethereum_serde_utils that Kolby added wasn't really needed because alloy-primitives has U256::from_str_radix(...).

  3. In order for everything to work, I also needed to fork @KolbyML 's ssz_types repo and make it depend on public ethereum_ssz and ethereum_serde_utils as well (commit link).

    • Going forward, we can merge my changes into his repo, as he is more likely to keep maintaining it long term.

This leaves us with only 3 non-public repos:

To-Do

@morph-dev morph-dev self-assigned this Apr 5, 2024
Copy link
Contributor

@njgheorghita njgheorghita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Looks good to me. Agreed that we should merge your ssz_types changes into @KolbyML 's repository. Whether or not that happens before or after merging this pr, I'll leave up to @KolbyML

@KolbyML
Copy link
Member

KolbyML commented Apr 5, 2024

KolbyML/ssz_types#1 I just merged this PR, cool find

Copy link
Member

@KolbyML KolbyML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@morph-dev morph-dev merged commit 842b78f into ethereum:master Apr 5, 2024
@morph-dev morph-dev deleted the crate_cleanup branch April 5, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants