fix: stream era1 block tuples #1246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njgheorghita
force-pushed
the
stream-era1
branch
3 times, most recently
from
67e830f to
9a4b6af
Compare
KolbyML
approved these changes
Apr 9, 2024
portal-bridge/src/bridge/era1.rs
Outdated
Comment on lines
168
to
169
| error!("Failed to get epoch from era1 file: {e}"); | ||
| return; |
There was a problem hiding this comment.
Suggested change
| error!("Failed to get epoch from era1 file: {e}"); | |
| return; | |
| panic!("Failed to get epoch from era1 file: {e}"); |
Wouldn't this make more sense as a panic! as this ends the program either way?
njgheorghita
force-pushed
the
stream-era1
branch
from
9a4b6af to
0bd6eec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Era1 files can get pretty large, and storing the entire deserialized object in memory can overwhelm our bridge nodes.
How was it fixed?
Iter over block tuples rather than store entire
Era1object in memoryUsing kurtosis to gossip epoch #1601:
Bridge node ram usage w/ current master branch
Bridge node ram usage w/ this pr
To-Do