Skip to content

Conversation

@KolbyML
Copy link
Member

@KolbyML KolbyML commented May 12, 2023

What was wrong?

I need clap to move grafana to TrinConfig as discussed in meeting on 3/11/2023
supercedes #698 (structout to clap conversion for trin-types, development has stalled for 2 weeks)

How was it fixed?

by updating trin-types from structopt to clap

@KolbyML KolbyML force-pushed the update-trin-types-from-structopt-to-clap branch from cbd1d77 to 4187387 Compare May 12, 2023 15:34
@KolbyML KolbyML marked this pull request as ready for review May 12, 2023 15:34
@KolbyML KolbyML requested a review from njgheorghita May 12, 2023 15:34
@KolbyML KolbyML changed the title Change trin-types from structopt to clap Update trin-types from structopt to clap May 12, 2023
@KolbyML KolbyML requested a review from ogenev May 12, 2023 15:34
@KolbyML KolbyML force-pushed the update-trin-types-from-structopt-to-clap branch from 4187387 to 3def51f Compare May 12, 2023 15:38
@KolbyML KolbyML self-assigned this May 12, 2023
Copy link
Member

@ogenev ogenev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🚀 .

@KolbyML KolbyML force-pushed the update-trin-types-from-structopt-to-clap branch from 3def51f to d439a29 Compare May 15, 2023 15:25
@KolbyML KolbyML merged commit c20ee54 into ethereum:master May 15, 2023
@KolbyML KolbyML deleted the update-trin-types-from-structopt-to-clap branch January 22, 2025 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants