This repository was archived by the owner on Apr 6, 2020. It is now read-only.
Make sure blockchain init is complete before adding blocks #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwasinger
force-pushed
the
fix-bc-general-state-tests
branch
from
8e4d9d3 to
23e4fd3
Compare
holgerd77
approved these changes
Sep 11, 2017
Member
holgerd77
left a comment
holgerd77
left a comment
There was a problem hiding this comment.
Looks good since this uses a mechanism already in place in the library.
I also tested this manually within ethereumjs-vm context.
Member
|
Just a last comment on this, was just skipping through the latest commits on this library, maybe name the branch after the problem fixed in this library and not in another one ( |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a race condition which caused Blockchain General State tests to break: #28