Si5351 init does not initialize the ref freq ] nor corr ] entries for clkin #98 #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orr[] entries for CLKIN etherkit#98 The workaround initializes ref_freq[] and corr[] for SI5351_PLL_INPUT_CLKIN as well as SI5351_PLL_INPUT_X0.
…orr[] entries for CLKIN etherkit#98 The workaround initializes ref_freq[] and corr[] for SI5351_PLL_INPUT_CLKIN as well as SI5351_PLL_INPUT_X0.
|
Thanks for the PR, I'll look at getting it in there soon. |
NT7S
requested changes
Oct 10, 2024
|
I can do that. This wasn't the first pull I've fouled with a .DS_STORE 😥
JimC
…On Thu, Oct 10, 2024, 12:34 Jason Milldrum ***@***.***> wrote:
***@***.**** requested changes on this pull request.
I believe that you'll have to remove the DS_Store file from the commit,
and then resend the PR. thank you.
—
Reply to this email directly, view it on GitHub
<#99 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKM3OICS67YG67D3MQCTBA3Z23JDXAVCNFSM6AAAAABOEHHGE2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGNRRGI2DEMRWHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
I've pushed removal of .DS_Store onto the Si5351-init-does-not... branch |
|
Done.
JimC
… On Oct 10, 2024, at 12:34 PM, Jason Milldrum ***@***.***> wrote:
@NT7S requested changes on this pull request.
I believe that you'll have to remove the DS_Store file from the commit, and then resend the PR. thank you.
—
Reply to this email directly, view it on GitHub <#99 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKM3OICS67YG67D3MQCTBA3Z23JDXAVCNFSM6AAAAABOEHHGE2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGNRRGI2DEMRWHA>.
You are receiving this because you authored the thread.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ugh... I forgot about the stupid MacOS .DS_Store file which got committed in addition to si5351.cpp (please delete the silly thing). :(