Gazebo plugin for logging #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At this stage it only supports logging of the ground truth
| pose_msg_.pose.orientation.y = pose_.rot.y; | ||
| pose_msg_.pose.orientation.z = pose_.rot.z; | ||
|
|
||
| bag_.write("ground_truth_pose", ros::Time::now(), pose_msg_); |
There was a problem hiding this comment.
I'd say we should use gazebo time (simulation time)?
|
All the logging as mentioned in issue #20 is supported apart from in_collision, the generic_pose_sensor, services and parameters. I guess we can add those once we have them. |
ffurrer
changed the title
| namespace_ = _sdf->GetElement("robotNamespace")->Get<std::string>(); | ||
| else | ||
| gzerr << "[gazebo_bag_plugin] Please specify a robotNamespace.\n"; | ||
| node_handle_ = new ros::NodeHandle(namespace_); |
There was a problem hiding this comment.
I don't know about gazebo namespaces, but are they always the same as the ros namespaces? shouldn't we take the ros namespaces here?
|
some comments otherwise this lgtm. |
Resolved Conflicts: mav_description/urdf/multirotor_base.urdf.xacro mav_gazebo_plugins/CMakeLists.txt
LorenzMeier
added a commit
to PX4/rotors_simulator
that referenced
this pull request
Jun 11, 2015
Depend on cv_bridge instead of opencv
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At this stage it only supports logging of the ground truth pose, but it can be tested :)