Skip to content

Conversation

@deanmsands3
Copy link
Contributor

Identify the Bug

#156

Description of the Change

Modified deferred_with_accumulator.cpp example
Added thread, chrono headers. Changed sleep() function to C++11

Alternate Designs

#ifdef Windows hack: https://stackoverflow.com/a/10918411/234826

Possible Drawbacks

Might add infinitesimal overhead for Unix systems compared to using straight sleep()

Verification Process

Checked on MinGW64 and Ubuntu x64

Release Notes

Replaced sleep function with C++11 equivalent.

@codecov-io
Copy link

Codecov Report

Merging #157 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #157   +/-   ##
======================================
  Coverage    95.3%   95.3%           
======================================
  Files          35      35           
  Lines        3197    3197           
======================================
  Hits         3047    3047           
  Misses        150     150

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ffda7b...375a974. Read the comment docs.

@etr
Copy link
Owner

etr commented Aug 14, 2019

Thanks for fixing.

@etr etr merged commit 6f2a0b8 into etr:master Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants