Skip to content

Allow explicit typing on selector using TypeVar with default Any #932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 24, 2025
Merged

Allow explicit typing on selector using TypeVar with default Any #932

merged 9 commits into from
Oct 24, 2025

Conversation

@leonarduschen
Copy link

@leonarduschen leonarduschen commented Oct 23, 2025 •
edited
Loading

Partially addresses #930

@leonarduschen leonarduschen marked this pull request as draft October 23, 2025 07:54
@ZipFile
Copy link
Contributor

ZipFile commented Oct 23, 2025

Could you rebase with latest develop branch? Failing tests should be fixed now (#933).

ZipFile
ZipFile reviewed Oct 23, 2025
View reviewed changes
ZipFile
ZipFile reviewed Oct 23, 2025
View reviewed changes
@leonarduschen leonarduschen force-pushed the allow-explicit-typing-on-selector branch from af98c97 to 673ae08 Compare October 24, 2025 02:45
@coveralls
Copy link

coveralls commented Oct 24, 2025 •
edited
Loading

Coverage Status

coverage: 94.956%. remained the same
when pulling 8e6f6df on leonarduschen:allow-explicit-typing-on-selector
into 059f78b on ets-labs:develop.

@leonarduschen
Copy link
Author

Thanks for the quick review!

I've rebased and addressed your comments @ZipFile.

@leonarduschen leonarduschen marked this pull request as ready for review October 24, 2025 03:20
@leonarduschen
Copy link
Author

Sorry, just added more changes:

  • Specify return type of Selector.__getattr__ and Selector.providers
  • Added more tests to make sure untyped Selector is not affected by these changes

@leonarduschen leonarduschen requested a review from ZipFile October 24, 2025 11:30
@ZipFile ZipFile merged commit 18e3252 into ets-labs:develop Oct 24, 2025
13 checks passed
@ZipFile
Copy link
Contributor

ZipFile commented Oct 24, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZipFile ZipFile ZipFile approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@leonarduschen @ZipFile @coveralls