Skip to content

[Ready] Changes centering calculations for modals #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

[Ready] Changes centering calculations for modals #11

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a17f860
Changes centering calculations for modals
p-shannon Feb 12, 2018
0dc24e2
Fix a syntax error
p-shannon Feb 12, 2018
704b6de
Creates an aligner for the modal and centers it using flex only when …
p-shannon Feb 14, 2018
c4f848e
Pacifiies the linter gods
p-shannon Feb 14, 2018
805f3df
Second time's the charm. (linting)
p-shannon Feb 14, 2018
c54d981
Remove dead options (also no longer use top)
lewisgoddard Feb 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions jQuery.leanModal2.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
//// Default Options
// Set some Defaults.
var defaults = {
top: '15vh',
overlayOpacity: 0.7,
closeButton: '.js-leanmodal-close',
disableCloseOnOverlayClick: false,
Expand All @@ -28,12 +27,14 @@
options = $.extend(defaults, options)

//// Close the Modal
// FUNCTION: Fade out the overlay and a passed identifier.
// FUNCTION: Fade out the overlay and a passed identifier while destroying the modal center aligner.
function leanModal_Close(modal_id) {
$('.js-leanmodal-overlay').fadeOut(options.fadeTime)
$(modal_id).fadeOut(options.fadeTime)
$('.js-leanmodal-overlay').unbind('click')
$(document).off('keyup')
$(modal_id).appendTo('body')
$('.js-leanmodal-aligner').remove()
}

//// There can be only one.
Expand Down Expand Up @@ -106,15 +107,13 @@
if ( options.modalCenter ) {
$(modal_id).css({
'display': 'block',
//'left': 50 + '%',
//'margin-left': - ( modal_width / 2 ) + 'px',
'margin-left': '50%',
'transform': 'translateX(-50%)',
'opacity': 0,
'position': 'fixed',
'top': options.top,
'z-index': 11000,
})
var style = 'display: flex; align-items: center; justify-content: center; position: fixed; top: 0px; width: 100vw; height: 100vh; z-index: 11000'
var modalAligner = $('<div class="js-leanmodal-aligner" style="' + style + '"></div')
$(modal_id).parent().append(modalAligner)
$(modal_id).appendTo('.js-leanmodal-aligner')
}

//// Curtain Up
Expand Down