Skip to content

Commit ccb4d83

Browse files
committed
Use if for depends_on validation
1 parent 3b38b5c commit ccb4d83

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

.github/scripts/validate-services-catalog.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -69,14 +69,14 @@ def error(errors, service, message)
6969
end
7070

7171
depends_on = service.fetch("depends_on", [])
72-
unless depends_on.is_a?(Array)
73-
error(errors, name, "depends_on must be a list when present")
74-
else
72+
if depends_on.is_a?(Array)
7573
depends_on.each do |dependency|
7674
unless services.key?(dependency)
7775
error(errors, name, "depends_on references unknown service #{dependency.inspect}")
7876
end
7977
end
78+
else
79+
error(errors, name, "depends_on must be a list when present")
8080
end
8181

8282
next unless service.key?("proto_consumer")

0 commit comments

Comments
 (0)