Skip to content

Conversation

@satyamsi
Copy link
Contributor

@satyamsi satyamsi commented Apr 10, 2025

Today fast agent is using default timeout for sse_client which happens to be 5 minutes. for production systems this is too low as our observation is that with 5mins of inactivity with an mcp server it becomes unusable.

@evalstate
Copy link
Owner

Can I just check what the 5x multiplication is for here (e.g. why not just set the desired value in the read_timeout_seconds)?

@satyamsi
Copy link
Contributor Author

Can I just check what the 5x multiplication is for here (e.g. why not just set the desired value in the read_timeout_seconds)?

There's two things:

  1. read_timeout_seconds if configured is used for the session as well. You'd want the transport to have a higher number. so either we introduce a new param for this all the way into the config or use a multiplier
  2. sse_client has a default time for 5*60

I have therefore just used - (configured or 60 (if not configured)) x 5 (multiplier)

If you'd like it a different way or just use configured or 5*60 I can do that as well

LMK how you'd like it.

@evalstate
Copy link
Owner

evalstate commented Apr 10, 2025 via email

@satyamsi satyamsi marked this pull request as draft April 10, 2025 23:31
@satyamsi
Copy link
Contributor Author

Testing in progress

@satyamsi satyamsi marked this pull request as ready for review April 11, 2025 01:09
@evalstate evalstate merged commit 0e155c3 into evalstate:main Apr 11, 2025
5 checks passed
@evalstate
Copy link
Owner

Great addition, thanks - added to the docs here: https://fast-agent.ai/mcp/#adding-an-sse-server

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants