Skip to content

refactoring #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 30, 2022
Merged

refactoring #15

merged 4 commits into from
Jan 30, 2022

Conversation

@evilmonkeyinc
Copy link
Owner

@evilmonkeyinc evilmonkeyinc commented Jan 30, 2022

various refactoring to improve runtime

  1. wildcard and recursive have reduced loops
  2. script, filter, expression now compile expression at build time and not runtime

@evilmonkeyinc
chore: update benchmark tests
917c754 
fix benchmark tests so they are more accurate
more of the other implementations worked when i used them correctly
@evilmonkeyinc
refactor: remove multiple loops
098ce1d 
remove multiple loops in recursive token
@evilmonkeyinc
refactor: remove extra loop in wildcard token
325ad13
@evilmonkeyinc
refactor: have script tokens compile expression
5133c0f 
update expression, script, and filter tokens to compile
expression when created and not runtime
@evilmonkeyinc evilmonkeyinc merged commit 542b5d3 into main Jan 30, 2022
@evilmonkeyinc evilmonkeyinc deleted the fix/double-loop branch January 30, 2022 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@evilmonkeyinc