-
Notifications
You must be signed in to change notification settings - Fork 824
Issue #148 cleanup of expired tokens #249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Simple implementation of cleanup strategy for expired tokens.
|
👍 very nice! |
|
To clarify cause I think it's only clear after looking at the code :) In this PR the idea is that a refresh_token can expire I would like to see if we can/should tie this in with the custom models for tokens and applications For example; Being able to use a custom refresh_token model that has an I would assume that different applications with different expire strategies could be fairly common. Like having a part of the api for IOS/Android apps that rarely (or never) expire and a public user/development api which should in expire in minutes or hours. |
|
I like this PR. Refresh tokens should not be immortal and should be removed at some point, they just lasts more longer than access tokens. |
|
I want to merge this PR :) Also add yourself to contributors. |
|
Documentation is only for What would be the most reasonable default for I will try to look at that and the conflicts as soon as I can. |
Simple implementation of cleanup strategy for expired tokens.
This cleanups expired
access_token's (when there is norefresh_token) and expired grant entries. Whenrefresh_token_expire_secondsis set it will expirerefresh_token's as well.Happy to write documentation if we decide to move forward with this or similar PR.
But I first wanted to submit this PR so we can get the discussion on how to expire token and cleanup the database periodically going.