-
Notifications
You must be signed in to change notification settings - Fork 236
specs: add validator set specs #1279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1279 +/- ##
==========================================
- Coverage 52.73% 52.65% -0.09%
==========================================
Files 52 52
Lines 6222 6222
==========================================
- Hits 3281 3276 -5
- Misses 2630 2634 +4
- Partials 311 312 +1 ☔ View full report in Codecov by Sentry. |
2bbb573 to
6274b44
Compare
WalkthroughThis update introduces a comprehensive document detailing the validator selection scheme in the Rollkit repository. It provides an in-depth explanation of the initialization of validators, the priority-based system for block proposers, and the management of validator sets, along with communication formats and implementation assumptions. Changes
Poem
TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- state/validators.md (1} hunks)
Files skipped from review due to trivial changes (1)
- state/validators.md
6274b44 to
484094c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- state/validators.md (1 hunks)
Files skipped from review due to trivial changes (1)
- state/validators.md
484094c to
a650557
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- state/validators.md (1 hunks)
Files skipped from review due to trivial changes (1)
- state/validators.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- state/validators.md (1 hunks)
Files skipped from review due to trivial changes (1)
- state/validators.md
a613043 to
5b8ca34
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- state/validators.md (1 hunks)
Files skipped from review due to trivial changes (1)
- state/validators.md
5b8ca34 to
84e3cdb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- state/validators.md (1 hunks)
Files skipped from review due to trivial changes (1)
- state/validators.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- state/validators.md (1 hunks)
Files skipped from review due to trivial changes (1)
- state/validators.md
## Overview This PR documents the specifications for the validator set. ## Checklist - [ ] New and updated code has appropriate documentation - [ ] New and updated code has new and/or updated testing - [ ] Required CI checks are passing - [ ] Visual proof for any user facing features like CLI or documentation updates - [ ] Linked issues closed with keywords <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Documentation** - Added a new document explaining the validator selection scheme in the Rollkit repository, including initialization, priority-based system for block proposers, and validator set management. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Manav Aggarwal <manavaggarwal1234@gmail.com>
Overview
This PR documents the specifications for the validator set.
Checklist
Summary by CodeRabbit