-
Notifications
You must be signed in to change notification settings - Fork 236
ci: ignore third_party directory for tests and linters #1310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe introduced changes in the Makefile provide a new feature that allows for ignoring specific directories during the testing and linting process. This is achieved by introducing a new variable Changes
TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- Makefile (1 hunks)
Additional comments: 1
Makefile (1)
- 3-13: The changes to the Makefile look good. The
IGNORE_DIRSvariable is a good addition for excluding certain directories from the testing and linting process. The use ofgrep -vEto exclude directories specified inIGNORE_DIRSfrom thepkgsvariable is a good approach. Ensure that theIGNORE_DIRSvariable is correctly set in the environment where the CI process runs.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1310 +/- ##
==========================================
- Coverage 53.64% 52.63% -1.02%
==========================================
Files 64 52 -12
Lines 7042 6222 -820
==========================================
- Hits 3778 3275 -503
+ Misses 2905 2635 -270
+ Partials 359 312 -47 ☔ View full report in Codecov by Sentry. |
nashqueue
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utAck
<!-- Please read and fill out this form before submitting your PR. Please make sure you have reviewed our contributors guide before submitting your first PR. --> ## Overview Since the `third_party` directory is just copy pasted code from other repos, primarily to avoid circular dependencies, we can ignore it in the testing and coverage reports since we don't want to make any changes here. All changes should be upstreamed and then re-copied in. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Tests** - Introduced an option to ignore specific directories during testing and linting for more flexible configuration. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Overview
Since the
third_partydirectory is just copy pasted code from other repos, primarily to avoid circular dependencies, we can ignore it in the testing and coverage reports since we don't want to make any changes here. All changes should be upstreamed and then re-copied in.Summary by CodeRabbit