Debug API #44
Merged
Debug API #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@jakelang what do you think, should we expose these? Need to squash this first. |
jakelang
reviewed
Apr 11, 2019
| @@ -0,0 +1,10 @@ | |||
| /// The native debug interface exposed to the ewasm contract. These functions are for testing | |||
| /// purposes only. On a live VM, any bytecode trying to import these symbols will be rejected. | |||
| extern "C" { | |||
Member
There was a problem hiding this comment.
I think adding a feature flag for conditional compilation of these features would be useful.
Member
There was a problem hiding this comment.
@s1na make sure that the conditional compilation flag is not on the interface declaration, but instead the pub mod debug; statement in the parent module.
Collaborator
Author
There was a problem hiding this comment.
Yeah good idea Jake. Updated the code, is this what you meant?
axic
requested changes
Apr 11, 2019
Member
axic
left a comment
axic
left a comment
There was a problem hiding this comment.
Please add a feature flag for these. Also squash the commits.
Update debug mod docs Add feature flag for debug api
axic
approved these changes
Apr 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds debug methods specified in ECI.
These methods would have to be remapped by chisel, but the remapping part is being refactored in wasmx/wasm-chisel#66, so I'll wait for that to be merged and then work on a PR.