This repository was archived by the owner on Sep 26, 2022. It is now read-only.
Enhanement/1 add initial implementation #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkilias
suggested changes
Nov 11, 2020
tkilias
suggested changes
Nov 11, 2020
Contributor
tkilias
left a comment
tkilias
left a comment
There was a problem hiding this comment.
We only need to extend the README and fix the package name
tkilias
reviewed
Nov 11, 2020
tkilias
suggested changes
Nov 11, 2020
Contributor
tkilias
left a comment
tkilias
left a comment
There was a problem hiding this comment.
Ok, this should be the last round. Besides the comments in the specific files. I saw that the code lives in the directory extension_downloading. This won't work if we build the package with poetry build. It will complain, that the name of the directory should be exasol_bucketfs_utils_python. We probably should also add the poetry build command to .github/workflows/pytest.yaml .
Co-authored-by: Torsten Kilias <tkilias@users.noreply.github.com>
tkilias
approved these changes
Nov 11, 2020
AnastasiiaSergienko
deleted the
enhanement/1_add_initial_implementation
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1