Skip to content
This repository was archived by the owner on Sep 26, 2022. It is now read-only.

Conversation

@MarleneKress79789
Copy link
Contributor

Closes #13

MarleneKress79789 and others added 20 commits November 10, 2021 10:50
Co-authored-by: Thomas Ubensee <34603111+tomuben@users.noreply.github.com>
Co-authored-by: Thomas Ubensee <34603111+tomuben@users.noreply.github.com>
…cation' into refactoring/#46-move-bucketfs-location

# Conflicts:
#	exasol_bucketfs_utils_python/bucketfs_factory.py
…ock-python, dill, pyexasol, pinned dill version to ^0.3.4
# Conflicts:
#	exasol_bucketfs_utils_python/abstract_bucketfs_location.py
#	exasol_bucketfs_utils_python/bucketfs_location.py
#	exasol_bucketfs_utils_python/localfs_mock_bucketfs_location.py
#	tests/test_bucketfs_location.py
#	tests/test_localfs_mock_bucketfs_location.py
Copy link
Contributor

@tomuben tomuben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my comments.
Also, what's the idea behind the mock? Is it used in integration tests in other projects?

@MarleneKress79789
Copy link
Contributor Author

Also, what's the idea behind the mock? Is it used in integration tests in other projects?

Torsten uses the Mock for fast testing when he does not want to set up a database in the background.

@tkilias
Copy link
Contributor

tkilias commented Nov 30, 2021

Also, what's the idea behind the mock? Is it used in integration tests in other projects?

Torsten uses the Mock for fast testing when he does not want to set up a database in the background.

Yep, I use it together with the udf-mock-python. We need the bucketfs location mock here, because it is instantiated via the Bucketfs factory, which works as injection point of the Mock for UDFs, because there is not other way to inject a object into UDFs.

Copy link
Contributor

@tomuben tomuben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my comment

@MarleneKress79789 MarleneKress79789 merged commit 6eb2aed into main Dec 7, 2021
@MarleneKress79789 MarleneKress79789 deleted the #13-Read_file_from_bucketfs_inside_a_UDF branch December 7, 2021 10:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Read file from bucketfs inside a UDF from /buckets

4 participants