-
Notifications
You must be signed in to change notification settings - Fork 3
#13 read file from bucketfs inside a udf #43
#13 read file from bucketfs inside a udf #43
Conversation
Co-authored-by: Thomas Ubensee <34603111+tomuben@users.noreply.github.com>
Co-authored-by: Thomas Ubensee <34603111+tomuben@users.noreply.github.com>
…cation' into refactoring/#46-move-bucketfs-location # Conflicts: # exasol_bucketfs_utils_python/bucketfs_factory.py
…ock-python, dill, pyexasol, pinned dill version to ^0.3.4
# Conflicts: # exasol_bucketfs_utils_python/abstract_bucketfs_location.py # exasol_bucketfs_utils_python/bucketfs_location.py # exasol_bucketfs_utils_python/localfs_mock_bucketfs_location.py # tests/test_bucketfs_location.py # tests/test_localfs_mock_bucketfs_location.py
tomuben
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check my comments.
Also, what's the idea behind the mock? Is it used in integration tests in other projects?
Torsten uses the Mock for fast testing when he does not want to set up a database in the background. |
Yep, I use it together with the udf-mock-python. We need the bucketfs location mock here, because it is instantiated via the Bucketfs factory, which works as injection point of the Mock for UDFs, because there is not other way to inject a object into UDFs. |
tomuben
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check my comment
Closes #13