This repository was archived by the owner on Sep 26, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3
#66: Corrected listing method for local operations #67
Merged
umitbuyuksahin
merged 13 commits into
main
from
bug/#66-correct-listing-method-for-local-operations
May 18, 2022
Merged
#66: Corrected listing method for local operations #67
umitbuyuksahin
merged 13 commits into
main
from
bug/#66-correct-listing-method-for-local-operations
May 18, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkilias
suggested changes
May 17, 2022
tkilias
suggested changes
May 17, 2022
tkilias
suggested changes
May 17, 2022
tkilias
reviewed
May 17, 2022
tomuben
reviewed
May 17, 2022
tomuben
reviewed
May 17, 2022
Contributor
tomuben
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my comments
Co-authored-by: Thomas Ubensee <34603111+tomuben@users.noreply.github.com>
tomuben
previously approved these changes
May 17, 2022
Contributor
tomuben
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Let's see feedback from @tkilias
tkilias
suggested changes
May 18, 2022
tkilias
suggested changes
May 18, 2022
tkilias
suggested changes
May 18, 2022
tkilias
approved these changes
May 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #66