Skip to content

Conversation

@morazow
Copy link
Contributor

@morazow morazow commented Nov 12, 2021

Fixes #27.

@morazow morazow changed the title Initial migration to maven build tool #27: Migrated to maven build tool Nov 12, 2021
@morazow morazow marked this pull request as ready for review November 26, 2021 10:26
@morazow morazow requested a review from jakobbraun November 26, 2021 10:26
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Comment on lines 11 to 14
matrix:
include:
- { scala-version: 'scala2.12', pk-skip: true }
- { scala-version: 'scala2.13', pk-skip: false }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why does it skip pgp for 2.13?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skip is for project-keeper, okay I am going to rename it.

The main issue is that for dependency artifacts have _2.12 or _2.13 compatibility suffix. By default we use 2.13 version, but when I cross compile for other versions, these dependencies are not in changes or dependencies files (because of changed suffix). So I skip project-keeper checks for them.

morazow and others added 2 commits November 26, 2021 12:10
Co-authored-by: jakobbraun <jakob.braun@posteo.de>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jakobbraun jakobbraun self-requested a review November 26, 2021 11:27
@morazow morazow merged commit c8596ef into main Nov 26, 2021
@morazow morazow deleted the refactoring/#27-move-to-maven branch November 26, 2021 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move to maven build tool

3 participants