#29: Added Jacoco coverage plugin and fixed Sonar coverage badge

.github/workflows/ci-build.yml

@@ -56,7 +56,7 @@ jobs:
       - name: Sonar analysis
         if: ${{ env.SONAR_TOKEN != null && startsWith(matrix.scala-version, 'scala2.13') }}
         run: |
-          mvn --batch-mode scoverage:report org.sonarsource.scanner.maven:sonar-maven-plugin:sonar \
+          mvn --batch-mode org.sonarsource.scanner.maven:sonar-maven-plugin:sonar \
               -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn \
               -DtrimStackTrace=false \
               -P${{ matrix.scala-version }} \

dependencies.md

@@ -16,37 +16,37 @@
 
 ## Test Dependencies
 
-| Dependency                  | License                                   |
-| --------------------------- | ----------------------------------------- |
-| [scalatest][15]             | [the Apache License, ASL Version 2.0][16] |
-| [scalatestplus-mockito][17] | [Apache-2.0][16]                          |
-| [mockito-core][18]          | [The MIT License][19]                     |
+| Dependency                                | License                                   |
+| ----------------------------------------- | ----------------------------------------- |
+| [scalatest][15]                           | [the Apache License, ASL Version 2.0][16] |
+| [scalatestplus-mockito][17]               | [Apache-2.0][16]                          |
+| [mockito-core][18]                        | [The MIT License][19]                     |
+| [EqualsVerifier | release normal jar][20] | [Apache License, Version 2.0][7]          |
 
 ## Plugin Dependencies
 
 | Dependency                                              | License                                       |
 | ------------------------------------------------------- | --------------------------------------------- |
-| [SonarQube Scanner for Maven][20]                       | [GNU LGPL 3][21]                              |
-| [Apache Maven Compiler Plugin][22]                      | [Apache License, Version 2.0][7]              |
-| [Apache Maven Enforcer Plugin][23]                      | [Apache License, Version 2.0][7]              |
-| [Maven Flatten Plugin][24]                              | [Apache Software Licenese][9]                 |
-| [org.sonatype.ossindex.maven:ossindex-maven-plugin][25] | [ASL2][9]                                     |
-| [Reproducible Build Maven Plugin][26]                   | [Apache 2.0][9]                               |
-| [scala-maven-plugin][27]                                | [Public domain (Unlicense)][28]               |
-| [Maven Surefire Plugin][29]                             | [Apache License, Version 2.0][7]              |
-| [Versions Maven Plugin][30]                             | [Apache License, Version 2.0][7]              |
-| [Apache Maven Deploy Plugin][31]                        | [Apache License, Version 2.0][7]              |
-| [Apache Maven GPG Plugin][32]                           | [Apache License, Version 2.0][7]              |
-| [Apache Maven Source Plugin][33]                        | [Apache License, Version 2.0][7]              |
-| [Apache Maven Javadoc Plugin][34]                       | [Apache License, Version 2.0][7]              |
-| [Nexus Staging Maven Plugin][35]                        | [Eclipse Public License][36]                  |
-| [JaCoCo :: Maven Plugin][37]                            | [Eclipse Public License 2.0][38]              |
-| [error-code-crawler-maven-plugin][39]                   | [MIT][5]                                      |
-| [ScalaTest Maven Plugin][40]                            | [the Apache License, ASL Version 2.0][16]     |
-| [Apache Maven Assembly Plugin][41]                      | [Apache License, Version 2.0][7]              |
-| [OpenFastTrace Maven Plugin][42]                        | [GNU General Public License v3.0][43]         |
-| [Project keeper maven plugin][44]                       | [The MIT License][45]                         |
-| [SCoverage Maven Plugin][46]                            | [The Apache Software License, Version 2.0][9] |
+| [SonarQube Scanner for Maven][21]                       | [GNU LGPL 3][22]                              |
+| [Apache Maven Compiler Plugin][23]                      | [Apache License, Version 2.0][7]              |
+| [Apache Maven Enforcer Plugin][24]                      | [Apache License, Version 2.0][7]              |
+| [Maven Flatten Plugin][25]                              | [Apache Software Licenese][9]                 |
+| [org.sonatype.ossindex.maven:ossindex-maven-plugin][26] | [ASL2][9]                                     |
+| [Reproducible Build Maven Plugin][27]                   | [Apache 2.0][9]                               |
+| [scala-maven-plugin][28]                                | [Public domain (Unlicense)][29]               |
+| [Maven Surefire Plugin][30]                             | [Apache License, Version 2.0][7]              |
+| [Versions Maven Plugin][31]                             | [Apache License, Version 2.0][7]              |
+| [Apache Maven Deploy Plugin][32]                        | [Apache License, Version 2.0][7]              |
+| [Apache Maven GPG Plugin][33]                           | [Apache License, Version 2.0][7]              |
+| [Apache Maven Source Plugin][34]                        | [Apache License, Version 2.0][7]              |
+| [Apache Maven Javadoc Plugin][35]                       | [Apache License, Version 2.0][7]              |
+| [Nexus Staging Maven Plugin][36]                        | [Eclipse Public License][37]                  |
+| [JaCoCo :: Maven Plugin][38]                            | [Eclipse Public License 2.0][39]              |
+| [error-code-crawler-maven-plugin][40]                   | [MIT][5]                                      |
+| [ScalaTest Maven Plugin][41]                            | [the Apache License, ASL Version 2.0][16]     |
+| [Apache Maven Assembly Plugin][42]                      | [Apache License, Version 2.0][7]              |
+| [OpenFastTrace Maven Plugin][43]                        | [GNU General Public License v3.0][44]         |
+| [Project keeper maven plugin][45]                       | [The MIT License][46]                         |
 | [Scalastyle Maven Plugin][47]                           | [Apache 2.0][14]                              |
 | [spotless-maven-plugin][48]                             | [The Apache Software License, Version 2.0][7] |
 | [scalafix-maven-plugin][49]                             | [BSD-3-Clause][50]                            |
@@ -76,33 +76,33 @@
 [17]: https://github.com/scalatest/scalatestplus-mockito
 [18]: https://github.com/mockito/mockito
 [19]: https://github.com/mockito/mockito/blob/main/LICENSE
-[20]: http://sonarsource.github.io/sonar-scanner-maven/
-[21]: http://www.gnu.org/licenses/lgpl.txt
-[22]: https://maven.apache.org/plugins/maven-compiler-plugin/
-[23]: https://maven.apache.org/enforcer/maven-enforcer-plugin/
-[24]: https://www.mojohaus.org/flatten-maven-plugin/
-[25]: https://sonatype.github.io/ossindex-maven/maven-plugin/
-[26]: http://zlika.github.io/reproducible-build-maven-plugin
-[27]: http://github.com/davidB/scala-maven-plugin
-[28]: http://unlicense.org/
-[29]: https://maven.apache.org/surefire/maven-surefire-plugin/
-[30]: http://www.mojohaus.org/versions-maven-plugin/
-[31]: https://maven.apache.org/plugins/maven-deploy-plugin/
-[32]: https://maven.apache.org/plugins/maven-gpg-plugin/
-[33]: https://maven.apache.org/plugins/maven-source-plugin/
-[34]: https://maven.apache.org/plugins/maven-javadoc-plugin/
-[35]: http://www.sonatype.com/public-parent/nexus-maven-plugins/nexus-staging/nexus-staging-maven-plugin/
-[36]: http://www.eclipse.org/legal/epl-v10.html
-[37]: https://www.jacoco.org/jacoco/trunk/doc/maven.html
-[38]: https://www.eclipse.org/legal/epl-2.0/
-[39]: https://github.com/exasol/error-code-crawler-maven-plugin
-[40]: https://www.scalatest.org/user_guide/using_the_scalatest_maven_plugin
-[41]: https://maven.apache.org/plugins/maven-assembly-plugin/
-[42]: https://github.com/itsallcode/openfasttrace-maven-plugin
-[43]: https://www.gnu.org/licenses/gpl-3.0.html
-[44]: https://github.com/exasol/project-keeper/
-[45]: https://github.com/exasol/project-keeper/blob/main/LICENSE
-[46]: https://scoverage.github.io/scoverage-maven-plugin/1.4.11/
+[20]: https://www.jqno.nl/equalsverifier
+[21]: http://sonarsource.github.io/sonar-scanner-maven/
+[22]: http://www.gnu.org/licenses/lgpl.txt
+[23]: https://maven.apache.org/plugins/maven-compiler-plugin/
+[24]: https://maven.apache.org/enforcer/maven-enforcer-plugin/
+[25]: https://www.mojohaus.org/flatten-maven-plugin/
+[26]: https://sonatype.github.io/ossindex-maven/maven-plugin/
+[27]: http://zlika.github.io/reproducible-build-maven-plugin
+[28]: http://github.com/davidB/scala-maven-plugin
+[29]: http://unlicense.org/
+[30]: https://maven.apache.org/surefire/maven-surefire-plugin/
+[31]: http://www.mojohaus.org/versions-maven-plugin/
+[32]: https://maven.apache.org/plugins/maven-deploy-plugin/
+[33]: https://maven.apache.org/plugins/maven-gpg-plugin/
+[34]: https://maven.apache.org/plugins/maven-source-plugin/
+[35]: https://maven.apache.org/plugins/maven-javadoc-plugin/
+[36]: http://www.sonatype.com/public-parent/nexus-maven-plugins/nexus-staging/nexus-staging-maven-plugin/
+[37]: http://www.eclipse.org/legal/epl-v10.html
+[38]: https://www.jacoco.org/jacoco/trunk/doc/maven.html
+[39]: https://www.eclipse.org/legal/epl-2.0/
+[40]: https://github.com/exasol/error-code-crawler-maven-plugin
+[41]: https://www.scalatest.org/user_guide/using_the_scalatest_maven_plugin
+[42]: https://maven.apache.org/plugins/maven-assembly-plugin/
+[43]: https://github.com/itsallcode/openfasttrace-maven-plugin
+[44]: https://www.gnu.org/licenses/gpl-3.0.html
+[45]: https://github.com/exasol/project-keeper/
+[46]: https://github.com/exasol/project-keeper/blob/main/LICENSE
 [47]: http://www.scalastyle.org
 [48]: https://github.com/diffplug/spotless
 [49]: https://github.com/evis/scalafix-maven-plugin

doc/changes/changelog.md

@@ -1,5 +1,6 @@
 # Changes
 
+* [0.4.3](changes_0.4.3.md)
 * [0.4.2](changes_0.4.2.md)
 * [0.4.1](changes_0.4.1.md)
 * [0.4.0](changes_0.4.0.md)

doc/changes/changes_0.4.3.md

@@ -0,0 +1,19 @@
+# Import Export UDF Common Scala 0.4.3, released 2022-??-??
+
+Code name:
+
+## Summary
+
+## Refactoring
+
+* #29: Changed to Jacoco coverage plugin and fixed Sonar coverage badge
+
+## Dependency Updates
+
+### Test Dependency Updates
+
+* Added `nl.jqno.equalsverifier:equalsverifier:3.10.1`
+
+### Plugin Dependency Updates
+
+* Removed `org.scoverage:scoverage-maven-plugin:1.4.11`

pk_generated_parent.pom

@@ -3,7 +3,7 @@
     <modelVersion>4.0.0</modelVersion>
     <groupId>com.exasol</groupId>
     <artifactId>import-export-udf-common-scala-generated-parent</artifactId>
-    <version>0.4.2</version>
+    <version>0.4.3</version>
     <packaging>pom</packaging>
     <properties>
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>

pom.xml

@@ -3,10 +3,16 @@
     <modelVersion>4.0.0</modelVersion>
     <groupId>com.exasol</groupId>
     <artifactId>import-export-udf-common-scala</artifactId>
-    <version>0.4.2</version>
+    <version>0.4.3</version>
     <name>Import Export UDF Common Scala</name>
     <description>Common import export libraries used in Exasol user defined functions</description>
     <url>https://github.com/exasol/import-export-udf-common-scala/</url>
+    <parent>
+        <artifactId>import-export-udf-common-scala-generated-parent</artifactId>
+        <groupId>com.exasol</groupId>
+        <version>0.4.3</version>
+        <relativePath>pk_generated_parent.pom</relativePath>
+    </parent>
     <properties>
         <!-- runtime dependency versions -->
         <exasol.api.version>6.1.7</exasol.api.version>
@@ -20,6 +26,8 @@
         <scalatest.version>3.2.13</scalatest.version>
         <scalatestplus.version>1.0.0-M2</scalatestplus.version>
         <mockito.version>4.6.1</mockito.version>
+        <sonar.sources>.</sonar.sources>
+        <sonar.inclusions>src/main/**</sonar.inclusions>
     </properties>
     <distributionManagement>
         <snapshotRepository>
@@ -139,6 +147,12 @@
             <version>${mockito.version}</version>
             <scope>test</scope>
         </dependency>
+        <dependency>
+            <groupId>nl.jqno.equalsverifier</groupId>
+            <artifactId>equalsverifier</artifactId>
+            <version>3.10.1</version>
+            <scope>test</scope>
+        </dependency>
     </dependencies>
     <build>
         <finalName>${project.artifactId}_${scala.compat.version}-${project.version}</finalName>
@@ -217,26 +231,31 @@
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-surefire-plugin</artifactId>
-                <configuration>
-                    <skipTests>true</skipTests>
-                </configuration>
+                <executions>
+                    <execution>
+                        <id>default-test</id>
+                        <phase>none</phase>
+                    </execution>
+                </executions>
             </plugin>
             <plugin>
                 <groupId>org.scalatest</groupId>
                 <artifactId>scalatest-maven-plugin</artifactId>
                 <version>2.0.2</version>
                 <configuration>
                     <junitxml>.</junitxml>
-                    <filereports>TestSuite.txt</filereports>
-                    <argLine>-Djava.util.logging.config.file=src/test/resources/logging.properties</argLine>
-                    <reportsDirectory>${project.build.directory}/surefire-reports</reportsDirectory>
+                    <argLine>-Djava.util.logging.config.file=src/test/resources/logging.properties ${argLine}</argLine>
                 </configuration>
                 <executions>
                     <execution>
                         <id>test</id>
                         <goals>
                             <goal>test</goal>
                         </goals>
+                        <configuration>
+                            <filereports>TestSuite.txt</filereports>
+                            <reportsDirectory>${project.build.directory}/surefire-reports</reportsDirectory>
+                        </configuration>
                     </execution>
                 </executions>
             </plugin>
@@ -295,16 +314,6 @@
                     </execution>
                 </executions>
             </plugin>
-            <plugin>
-                <groupId>org.scoverage</groupId>
-                <artifactId>scoverage-maven-plugin</artifactId>
-                <version>1.4.11</version>
-                <configuration>
-                    <scalaVersion>${scala.version}</scalaVersion>
-                    <aggregate>true</aggregate>
-                    <highlighting>true</highlighting>
-                </configuration>
-            </plugin>
             <plugin>
                 <groupId>org.scalastyle</groupId>
                 <artifactId>scalastyle-maven-plugin</artifactId>
@@ -395,10 +404,4 @@
             </properties>
         </profile>
     </profiles>
-    <parent>
-        <artifactId>import-export-udf-common-scala-generated-parent</artifactId>
-        <groupId>com.exasol</groupId>
-        <version>0.4.2</version>
-        <relativePath>pk_generated_parent.pom</relativePath>
-    </parent>
 </project>

src/test/scala/com/exasol/common/PropertiesParserTest.scala

@@ -1,5 +1,6 @@
 package com.exasol.common
 
+import nl.jqno.equalsverifier.EqualsVerifier
 import org.scalatest.funsuite.AnyFunSuite
 
 class PropertiesParserTest extends AnyFunSuite {
@@ -28,4 +29,8 @@ class PropertiesParserTest extends AnyFunSuite {
     assert(parser.mapToString(Map.empty[String, String]) === "")
   }
 
+  test("verify contract") {
+    EqualsVerifier.forClass(classOf[PropertiesParser]).verify()
+  }
+
 }