-
Notifications
You must be signed in to change notification settings - Fork 2
add v8 to ci #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
add v8 to ci #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaklakariada
requested changes
Feb 7, 2024
...t/java/com/exasol/adapter/dialects/postgresql/PostgresVirtualSchemaIntegrationTestSetup.java
Outdated
Show resolved
Hide resolved
...t/java/com/exasol/adapter/dialects/postgresql/PostgresVirtualSchemaIntegrationTestSetup.java
Outdated
Show resolved
Hide resolved
kaklakariada
requested changes
Feb 28, 2024
src/main/java/com/exasol/adapter/dialects/postgresql/PostgresSQLSqlGenerationVisitor.java
Show resolved
Hide resolved
src/test/java/com/exasol/adapter/dialects/postgresql/PostgresSQLSqlGenerationVisitorTest.java
Outdated
Show resolved
Hide resolved
...t/java/com/exasol/adapter/dialects/postgresql/PostgresVirtualSchemaIntegrationTestSetup.java
Outdated
Show resolved
Hide resolved
...t/java/com/exasol/adapter/dialects/postgresql/PostgresVirtualSchemaIntegrationTestSetup.java
Outdated
Show resolved
Hide resolved
kaklakariada
approved these changes
Feb 28, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #68
Closes #78
The behaviour when it comes to character sets is now simplified,
The target char set is now always UTF-8.
The
IMPORT_DATA_TYPES
property (and valueFROM_RESULT_SET
) are now deprecated (change in vs-common-jdbc):An exception will be thrown when users use
FROM_RESULT_SET
. The exception message warns the user that the value is no longer supported and the property itself is also deprecated.Various broken scalar time-related extraction functions for dates and timestamps in the virtual schema are now fixed:
year
,month
,day
,hour
,minute
,second
.Scalar
division
(/
) which was broken in some cases now also works correctly.Tests for
current_schema
are currently disabled, this is because of a discovered compiler bug: #79 .These tests will be re-evaluated later when there is more clarity about this issue.
We also updated dependencies and resolved the following 2 CVEs in test dependency
org.apache.commons:commons-compress
:We also updated dependencies and resolved the following CVE in test dependency
org.postgresql:postgresql:
: