Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions doc/changes/unreleased.md
Original file line number Diff line number Diff line change
@@ -1 +1,6 @@
# Unreleased


## Doc

* #204: Added a guideline for removing `ci-job` from workflow `pr-merge.yml`
13 changes: 13 additions & 0 deletions doc/user_guide/workflows.rst
Original file line number Diff line number Diff line change
Expand Up @@ -90,3 +90,16 @@ and add the following content:

.. literalinclude:: ../../exasol/toolbox/templates/github/workflows/pr-merge.yml
:language: yaml

In order to make merging to the main branch faster you can skip running the
tests again in this workflow.

Before removing the ``ci-job`` from the workflow by please make sure the
following prerequisites are met, as in some circumstances these tests might be
the last or even only chance to detect problems.

* GitHub branch protection for main branch is properly configured.
* All dependencies are pointing to proper pypi packages in specific versions, i.e. no
dependencies to the main branch of other git repositories.
* Development branches are short-lived and merged to main branch soon after
finishing tests in the context of a pull request.
3 changes: 3 additions & 0 deletions exasol/toolbox/templates/github/workflows/pr-merge.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ on:

jobs:

# This job can be removed if certain preconditions are met. See
# https://exasol.github.io/python-toolbox/user_guide/workflows.html#pr-merge-workflow

ci-job:
name: Checks
uses: ./.github/workflows/checks.yml
Expand Down