Skip to content

#27: fixed sonar findings #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AnastasiiaSergienko merged 2 commits into from
Jul 6, 2020
Merged

#27: fixed sonar findings #86

AnastasiiaSergienko merged 2 commits into from
Jul 6, 2020

Conversation

@AnastasiiaSergienko
Copy link
Contributor

@AnastasiiaSergienko AnastasiiaSergienko commented Jul 6, 2020 •
edited
Loading

Closes #27

@AnastasiiaSergienko AnastasiiaSergienko added the refactoring Code improvement without behavior change label Jul 6, 2020
@AnastasiiaSergienko AnastasiiaSergienko self-assigned this Jul 6, 2020
redcatbear
redcatbear previously approved these changes Jul 6, 2020
View reviewed changes
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 6, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

90.2% 90.2% Coverage
0.0% 0.0% Duplication

@AnastasiiaSergienko AnastasiiaSergienko merged commit e28937c into master Jul 6, 2020
@AnastasiiaSergienko AnastasiiaSergienko deleted the refactoring/27_fix_sonar_findings branch July 6, 2020 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@redcatbear redcatbear redcatbear left review comments

Assignees

@AnastasiiaSergienko AnastasiiaSergienko

Labels

refactoring Code improvement without behavior change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix Sonar code smells

3 participants

@AnastasiiaSergienko @redcatbear