feat: Arabic font support with auto-switch and split font picker#11399
Open
AhmedAl-Bahrawy wants to merge 2 commits into
Open
feat: Arabic font support with auto-switch and split font picker#11399AhmedAl-Bahrawy wants to merge 2 commits into
AhmedAl-Bahrawy wants to merge 2 commits into
Conversation
Add 5 Arabic fonts (Noto Naskh Arabic, Lemonada, Baloo Bhaijaan 2, Cairo Play, Changa) loaded from Google Fonts CDN. - Split font picker into Arabic/English sections with section headers - Auto-switch between Arabic/Latin fonts based on text input script - Track last used font per script (lastArabicFontFamily, lastLatinFontFamily) - Lemonada is the default Arabic font - Font names with spaces are properly quoted in CSS font-family output - Fix FontFaceSet.check() SyntaxError for multi-word font names - Quote font-family in @font-face CSS export
…and lastLatinFontFamily properties
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add comprehensive Arabic font support to Excalidraw with 5 new Arabic fonts, a split font picker, and automatic script-based font switching.
Changes
lastArabicFontFamilyandlastLatinFontFamilyapp state properties remember the last font used per scriptFontFaceSet.check()SyntaxError@font-faceCSS export now quotes font-family for names with spacesFiles changed
@excalidraw/commonconstants.ts,font-metadata.ts,utils.ts@excalidraw/excalidrawFonts.ts,ExcalidrawFontFace.ts,textWysiwyg.tsx,FontPickerList.tsx,appState.ts,types.ts,actionProperties.tsx,locales/en.json,CHANGELOG.mdLemonada/,BalooBhaijaan2/,CairoPlay/,Changa/,NotoNaskhArabic/