Skip to content

🐛 FIX: empty lines after blockquote+footnote #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2021
Merged

🐛 FIX: empty lines after blockquote+footnote #134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions markdown_it/parser_block.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,12 +81,12 @@ def tokenize(
# i.e. latest empty line should not count
state.tight = not hasEmptyLines

line = state.line

# paragraph might "eat" one newline after it in nested lists
if state.isEmpty(state.line - 1):
if (line - 1) < endLine and state.isEmpty(line - 1):
hasEmptyLines = True

line = state.line

if line < endLine and state.isEmpty(line):
hasEmptyLines = True
line += 1
Expand Down
30 changes: 29 additions & 1 deletion tests/test_plugins/fixtures/footnote.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,4 +297,32 @@ hij</p>
<a href="#fnref1" class="footnote-backref">↩︎</a></li>
</ol>
</section>
.
.

issue-133
.
> b [^1]

Some text

> c

[^1]: d


.
<blockquote>
<p>b <sup class="footnote-ref"><a href="#fn1" id="fnref1">[1]</a></sup></p>
</blockquote>
<p>Some text</p>
<blockquote>
<p>c</p>
</blockquote>
<hr class="footnotes-sep">
<section class="footnotes">
<ol class="footnotes-list">
<li id="fn1" class="footnote-item"><p>d <a href="#fnref1" class="footnote-backref">↩︎</a></p>
</li>
</ol>
</section>
.
4 changes: 3 additions & 1 deletion tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,9 @@ envlist = py37
usedevelop = true

[testenv:py{36,37,38}]
extras = testing
extras =
linkify
testing
commands = pytest {posargs}

[testenv:py{36,37,38}-bench-core]
Expand Down