Skip to content

Conversation

@hukkin
Copy link
Contributor

@hukkin hukkin commented Mar 11, 2021

It seems to me like linkify link tokens have incorrect nesting levels. This PR fixes that.

This seems like a bug inherited from upstream. I'll make a quick PR there as well. EDIT: On closer inspection this seems like a porting issue, so not making an upstream PR.

@codecov
Copy link

codecov bot commented Mar 11, 2021

Codecov Report

Merging #142 (cc16818) into master (de09ccf) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #142   +/-   ##
=======================================
  Coverage   96.43%   96.44%           
=======================================
  Files          72       72           
  Lines        3202     3204    +2     
=======================================
+ Hits         3088     3090    +2     
  Misses        114      114           
Flag Coverage Δ
pytests 96.44% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
markdown_it/rules_core/linkify.py 98.87% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de09ccf...cc16818. Read the comment docs.

@chrisjsewell
Copy link
Member

thanks @hukkinj1
Hey @tsutsu3, since you wrote this code, perhaps you want to comment if you see any reason why this should not be case?

@tsutsu3
Copy link
Contributor

tsutsu3 commented Mar 12, 2021

As @hukkinj1 pointed out, it is a porting error 🙏
This fix is correct

@chrisjsewell
Copy link
Member

cheers!

@chrisjsewell chrisjsewell merged commit ab287be into executablebooks:master Mar 12, 2021
@hukkin hukkin deleted the fix-linkify-levels branch March 16, 2021 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants