-
Notifications
You must be signed in to change notification settings - Fork 86
🧪 TESTS: Add PyPy3 to matrix #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #65 +/- ##
=======================================
Coverage 95.40% 95.40%
=======================================
Files 75 75
Lines 3745 3745
=======================================
Hits 3573 3573
Misses 172 172
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
I am not sure what are the implications of this. Could you explain a bit the reasoning for adding this extra job to the test suite? What's the added benefit over testing the different packages of python? Do we expect these tests to be any more brittle or require more maintenance than others? |
|
Oh I was just gonna merge this, if the tests pass and it doesn't take too long to run, I see no problem to adding it |
|
sounds good 👍 |
The reasoning is, since there is a PyPy Trove classifier in the package's metadata, it's probably good practice to back that up by testing it.
PyPy builds typically break if the package or a dependency are not pure Python (which is currently not the case for this package). |
chrisjsewell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cheers!
No description provided.