Skip to content

Conversation

@hukkin
Copy link
Contributor

@hukkin hukkin commented Oct 22, 2020

No description provided.

@codecov
Copy link

codecov bot commented Oct 22, 2020

Codecov Report

Merging #65 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #65   +/-   ##
=======================================
  Coverage   95.40%   95.40%           
=======================================
  Files          75       75           
  Lines        3745     3745           
=======================================
  Hits         3573     3573           
  Misses        172      172           
Flag Coverage Δ
pytests 95.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 510e2bf...fed818a. Read the comment docs.

@choldgraf
Copy link
Member

I am not sure what are the implications of this. Could you explain a bit the reasoning for adding this extra job to the test suite? What's the added benefit over testing the different packages of python? Do we expect these tests to be any more brittle or require more maintenance than others?

@chrisjsewell
Copy link
Member

Oh I was just gonna merge this, if the tests pass and it doesn't take too long to run, I see no problem to adding it

@choldgraf
Copy link
Member

sounds good 👍

@hukkin
Copy link
Contributor Author

hukkin commented Oct 23, 2020

Could you explain a bit the reasoning for adding this extra job to the test suite?

The reasoning is, since there is a PyPy Trove classifier in the package's metadata, it's probably good practice to back that up by testing it.

Do we expect these tests to be any more brittle

PyPy builds typically break if the package or a dependency are not pure Python (which is currently not the case for this package).

@chrisjsewell chrisjsewell self-requested a review October 31, 2020 10:16
Copy link
Member

@chrisjsewell chrisjsewell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cheers!

@chrisjsewell chrisjsewell changed the title TEST: Against PyPy 🧪 TESTS: Add PyPy3 to matrix Oct 31, 2020
@chrisjsewell chrisjsewell merged commit 901c180 into executablebooks:master Oct 31, 2020
@hukkin hukkin deleted the pypy branch October 31, 2020 10:52
@hukkin hukkin restored the pypy branch October 31, 2020 10:52
@hukkin hukkin deleted the pypy branch October 31, 2020 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants