🐛 FIX: _Entities.__contains__

[hukkin]

No description provided.

[codecov]

Codecov Report

Merging #69 into master will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master      #69   +/-   ##
=======================================
  Coverage   95.40%   95.40%           
=======================================
  Files          75       75           
  Lines        3745     3745           
=======================================
  Hits         3573     3573           
  Misses        172      172           

Flag	Coverage Δ
pytests	95.40% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
markdown_it/common/entities.py	91.66% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 901c180...ac5cd8f. Read the comment docs.

[hukkin]

@chrisjsewell btw, what do you think about replacing markdown_it.common.entities.DATA with

import html
DATA = html.entities.html5

[chrisjsewell]

what do you think about replacing markdown_it.common.entities.DATA with

they only have 106 keys in common, why the big difference?

len(set(DATA).intersection(set(html.entities.html5))) == 106

[hukkin]

Ah, I see. html.entities.html5 includes trailing semicolons whereas DATA does not. Explained here: https://docs.python.org/3/library/html.entities.html

Besides that I think the data should be the same.

[chrisjsewell]

yep thats more like it 👍 :

len(set([_+';' for _ in DATA]).intersection(set(html.entities.html5))) == len(DATA)

so yeh, if we account for this trailing ; in some fashion