Skip to content

Conversation

@hukkin
Copy link
Contributor

@hukkin hukkin commented Nov 12, 2020

This PR makes MarkdownIt.render not copy an env if it is an empty AttrDict, making it possible for a caller to capture changes made to env. This is in line with how MarkdownIt.parse method, and the JS implementation works.

@codecov
Copy link

codecov bot commented Nov 12, 2020

Codecov Report

Merging #77 (ea640bf) into master (b533d6d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #77   +/-   ##
=======================================
  Coverage   95.40%   95.40%           
=======================================
  Files          75       75           
  Lines        3746     3747    +1     
=======================================
+ Hits         3574     3575    +1     
  Misses        172      172           
Flag Coverage Δ
pytests 95.40% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
markdown_it/main.py 92.30% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b533d6d...ea640bf. Read the comment docs.

@chrisjsewell
Copy link
Member

cheers

@chrisjsewell chrisjsewell changed the title Don't copy empty env passed to MarkdownIt.render 🐛 FIX: MarkdownIt.render; don't copy empty env arg Nov 12, 2020
@chrisjsewell chrisjsewell merged commit 947d4c6 into executablebooks:master Nov 12, 2020
@hukkin hukkin deleted the mutate-env branch November 12, 2020 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants