🔧 MAINTAIN: keep GitHub Actions up to date #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: v4 will be released soon
KyleKing
commented
Oct 19, 2025
.github/workflows/tests.yml
Outdated
| path: dist/ | ||
| - name: Sign the dists with Sigstore | ||
| uses: sigstore/gh-action-sigstore-python@v2.1.1 | ||
| uses: sigstore/gh-action-sigstore-python@v3.0.0 |
Collaborator
Author
There was a problem hiding this comment.
Using this action isn't recommended (https://github.com/sigstore/gh-action-sigstore-python/blob/be60bbea7f8770c9c9673a8fabafec00df7f458f/README.md) because the SigStore version is encapsulated by the pypa/gh-action-pypi-publish action
The files modified during the pypi-publish action should be uploaded directly, right?
Collaborator
Author
There was a problem hiding this comment.
Although, I might just not have a good understanding of what the best practices are now and haven't been following the OIDC changes closely
Collaborator
There was a problem hiding this comment.
They're separate issues. The first action pushes to pypi and signs there. The second one signs the artifacts as part of the github release.
gaige
approved these changes
Oct 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to address CI failure: https://github.com/executablebooks/mdformat-footnote/actions/runs/18628585373/job/53110081204 and add Dependabot to keep Actions up to date in the future