[FIX] Dedent math block if nonzero indent_width found in context #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KyleKing
approved these changes
Aug 19, 2025
There was a problem hiding this comment.
Thanks, this looks good as well!
The only other change might be to update the PR title when merging following: https://github.com/executablebooks/.github/blob/master/CONTRIBUTING.md#commit-messages
Otherwise, I have no concerns
e13h
changed the title
e13h
force-pushed
the
fix-extra-indentation
branch
from
500edf8 to
9edf570
Compare
|
Great, thanks! I saw your recent commit to update the pipeline. I just rebased and force pushed, hopefully the pipeline will succeed now. I also updated the PR title. |
|
Would you be able to resolve the conflicts? Otherwise, I can do that tonight when I release a patch version! |
e13h
force-pushed
the
fix-extra-indentation
branch
from
9edf570 to
b008bd0
Compare
|
Conflicts resolved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37
Dedent the contents of the math block if
indent_widthis nonzero in the context. The parent renderer will add back the right amount of indentation.