Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Word count #48

Closed
wants to merge 2 commits into from
Closed

Word count #48

wants to merge 2 commits into from

Conversation

kotp
Copy link
Member

@kotp kotp commented Jun 12, 2017

Brings in the good work from @T-Edward on PR #37 and does the needed change on config.json

@kotp kotp requested a review from jtigger June 12, 2017 09:02
@kotp kotp requested review from iHiD and parkerl June 23, 2017 13:37
kytrinyx pushed a commit that referenced this pull request Jul 21, 2017
@kytrinyx
Copy link
Member

Merged in 1f86584

@kytrinyx kytrinyx closed this Jul 21, 2017
@kytrinyx kytrinyx deleted the word_count branch July 21, 2017 22:34
@kytrinyx
Copy link
Member

@kotp I can't find a test suite. I'm going to put this exercise in a branch and remove it from master.

@kytrinyx
Copy link
Member

I've put it here: https://github.com/exercism/bash/tree/word-count

@kotp
Copy link
Member Author

kotp commented Aug 3, 2017

Ouch, yes indeed.

@ilya-khadykin
Copy link
Contributor

ilya-khadykin commented Aug 13, 2017

Looks like it's still available in master and causes #77

It'll be a good idea to add a test suite rather than removing the exercise. I'll try to help with that

@kytrinyx
Copy link
Member

I'll still remove it from master, and we can add it back as soon as it has a test. Not sure how it stayed there (probably I forgot to push my change—it's been one of those months).

@kytrinyx
Copy link
Member

Indeed. The change was there on my local machine. sigh sorry about that.

@kotp
Copy link
Member Author

kotp commented Aug 13, 2017

I will definitely share the blame, @kytrinyx, for missing the lack of the test file and allowing it to get through.

@kytrinyx
Copy link
Member

It's all good ❤️

@kotp
Copy link
Member Author

kotp commented Aug 13, 2017

It just means I am in good company. 😜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants