Skip to content

dominoes: Fix reference to Eulerian graph in comment #2127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 12, 2022
Merged

dominoes: Fix reference to Eulerian graph in comment #2127

merged 1 commit into from
Oct 12, 2022

Conversation

dreig
Copy link
Contributor

@dreig dreig commented Oct 11, 2022

I believe this was a misprint. A graph that contains such a cycle is called Eulerian. See: https://mathworld.wolfram.com/EulerianGraph.html

@dreig
Fix reference to Eulerian graph in comment
26fac54 
I believe this was a misprint. A graph that contains such a cycle is called Eulerian. See: https://mathworld.wolfram.com/EulerianGraph.html
@dreig dreig changed the title Fix reference to Eulerian graph in comment dominoes: Fix reference to Eulerian graph in comment Oct 11, 2022
kytrinyx
kytrinyx approved these changes Oct 11, 2022
View reviewed changes
Copy link
Member

@kytrinyx kytrinyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure you're right. There is such a thing as a Euclidean Graph, apparently, (this is definitely beyond the scope of my knowledge), but in the context of Dominoes I'm pretty sure we want a Eulerian graph.

petertseng
petertseng approved these changes Oct 11, 2022
View reviewed changes
Copy link
Member

@petertseng petertseng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my fault

@kytrinyx kytrinyx requested a review from glennj October 11, 2022 17:46
@kytrinyx kytrinyx merged commit b5bfcda into exercism:main Oct 12, 2022
@dreig dreig deleted the patch-1 branch October 12, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErikSchierboom ErikSchierboom ErikSchierboom approved these changes

@kytrinyx kytrinyx kytrinyx approved these changes

@glennj glennj Awaiting requested review from glennj

+1 more reviewer

@petertseng petertseng petertseng approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dreig @ErikSchierboom @kytrinyx @petertseng