-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alternative Travis build #71
Conversation
OK, UUID issue looks like it's due to my repository being still named xpurescript (i.e. I still have x upfront). I guess that can be ignored, since the main build passes fine. Let me know about the other things. |
Hey @icyrockcom Seems sensible to me. My only gripe is the lack of semicolons in your Javascript ;) |
Sorry I don't have time to review right now, but if @lpil is happy, I say ship it. |
No worries, thanks @paf31! We can revisit later if needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm just teasing with the semicolons. Old habits die hard. I use prettier so I rarely type them myself.
Anyway, lets merge this :)
@lpil "Old habits die hard." Haha, true that! :) OK, thanks for merging. I'll do the rest in another PR. |
Work in progress PR, please do not merge this yet, see below for more (too much?) details.
This is an alternative Travis build setup. Here's what I changed:
Sample build that demonstrates how it works:
https://travis-ci.org/icyrockcom/xpurescript/builds/278841675
The build is failing due to linter failing on:
but otherwise goes fine (finished in ~18 minutes). Fixing the linter issue would make this a good build.
Can someone let me know if this is just updating the UUIDs? Easy to do, but I was wary after finding an issue which says something to the effect of "this will delete the exercise and all its history" (exercism/discussions#159 (comment)).
I have the following additional concerns:
If this approach is fine with you guys, I would like to polish it a bit more:
Let me know what you think, if you have additional comments / concerns. Most importantly, if I should go ahead in this direction and with the above changes.