-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement checks for raising messages with exceptions #1113
Conversation
b7dc4e3
to
ab1acd7
Compare
b85df2d
to
8cadf5b
Compare
I've held back the change to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you can confirm that most/all changes to README files (besides the insertion of the new Exception Messages
section) are simply reflecting the latest versions of the relevant problem descriptions, then LGTM.
@cmccandless, all changes reflect changes to the upstream problem descriptions. I had a look through and nothing significant appeared to be changing (except in |
(Fixes exercism#1080) * Add self.assertRaisesWithMessage method to relevant exercise tests - Uses self.assertRaisesRegex - Checks only for the presence of a message, not content * Add meaningful messages to failing examples * octal: Switch to using a context manager for exception tests
8cadf5b
to
b498eda
Compare
This issue has been automatically marked as |
Resolves #1080 by adding checks that all exceptions are raised with messages. The aim is to encourage learners to raise meaningful messages, but testing for meaningfulness isn't feasible, so this instead just tests that a message of non-zero length is passed when raising an exception.
TODO: