Update resistor-color-trio #1794
Conversation
|
This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested. If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos. For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping |
|
|
||
| def label | ||
| "Resistor value: #{to_s}" | ||
| "Resistor value: #{self}" |
Should we add "and adds template"? Otherwise, I would expect the update for the spec but not the template. |
On further thought, and given the reason for this was so that "one could be reverted..." including the template here is causing the same concern. The template should be done in the other PR where templates are done. |
|
I will remove the template but I will still keep the updated test file, since I think that is what you are meaning |
meatball133
force-pushed
the
update-resistor-color-trio
branch
from
f33b33e to
5830c59
Compare
Branched of #1792, update the exercise to be up to spec with problem spec. Adds tests for higher numbers.