Improve practice exercise generator script #1648
Conversation
Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>
…m4ron/rust-exercism into add-exercise-generator-script
…ompts, validate exercise difficulty, etc
…t-exercism into stub-generator-patch
.github/workflows/tests.yml
Outdated
| @@ -87,7 +87,9 @@ jobs: | |||
| uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c # v3.3.0 | |||
|
|
|||
| - name: Run shellcheck | |||
| uses: ludeeus/action-shellcheck@00cae500b08a931fb5698e11e79bfbd38e612a38 # v2.0.0 | |||
| uses: ludeeus/action-shellcheck@master | |||
There was a problem hiding this comment.
Could you revert back to using a commit as the version to use?
bin/add_practice_exercise
Outdated
|
|
||
| # ================================================== | ||
|
|
||
| # build configlet | ||
| # Build configlet | ||
| ./bin/fetch-configlet |
There was a problem hiding this comment.
This is trying to fetch configlet a second time. I guess this is no longer needed?
bin/add_practice_exercise
Outdated
| # Check if configlet is already fetched | ||
| if [ -e bin/configlet ]; then | ||
| message "success" "Configlet found!" | ||
| else | ||
| message "info" "Fetching configlet" | ||
| bin/fetch-configlet | ||
| message "success" "Fetched configlet successfully!" | ||
| fi |
There was a problem hiding this comment.
I would always fetch configlet, as that way you're guaranteed to work with the latest version.
dem4ron
changed the title
|
These commits should not have been 120 individual commits but instead combined into fewer commits that each contain only one operation. I think the organisation doesn't have an organisation-wide document for git commit discipline since last I checked it was track-level policy, so it is my fault for not having written a policy document for the track. Add yet another thing to the long list of things to do, then. |
|
@petertseng I'm very sorry, it is all my fault. I know I should've squashed the commits, but made a mistake. I thought squash-merge was the default behaviour as it is on most of the repos and clicked the green button out of excitement, but then realised my mistake. I'm very sorry, I feel very bad for messing up the timeline. |
localize function-scoped variables for similar reasonfunctionfrom function declarations and follow this convention everywhere so a function looks like this:fn_name(){ ... }.shellcheckrc- currently not seen by CI