Skip to content

fix get status code from sendgrid response class #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 14, 2017
Merged

fix get status code from sendgrid response class #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions Services/SendGridTransport.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ class SendGridTransport implements Swift_Transport {

/**
* Sendgrid api key.
*
*
* @var string
*/
private $sendGridApiKey;
Expand All @@ -55,10 +55,10 @@ public function stop() {

/**
* WARNING : $failedRecipients and return value are faked
*
*
* @param Swift_Mime_Message $message
* @param array $failedRecipients
* @return int
* @return int
*/
public function send(Swift_Mime_Message $message, &$failedRecipients = null) {

Expand Down Expand Up @@ -102,7 +102,7 @@ public function send(Swift_Mime_Message $message, &$failedRecipients = null) {
$prepareFailedRecipients[] = $email;
}
}

// process BCC
if ($bccArr = $message->getBcc()) {
foreach ($bccArr as $email => $name) {
Expand Down Expand Up @@ -135,19 +135,19 @@ public function send(Swift_Mime_Message $message, &$failedRecipients = null) {

// only 2xx status are ok
if (
$response->_status_code < self::STATUS_OK_SUCCESSFUL_MIN_RANGE ||
self::STATUS_SUCCESSFUL_MAX_RANGE < $response->_status_code ) {
$response->statusCode() < self::STATUS_OK_SUCCESSFUL_MIN_RANGE ||
self::STATUS_SUCCESSFUL_MAX_RANGE < $response->statusCode()) {

// to force big boom error uncomment this line
//throw new \Swift_TransportException("Error when sending message. Return status :".$response->_status_code);
//throw new \Swift_TransportException("Error when sending message. Return status :".$response->statusCode());

// copy failed recipients
foreach ($prepareFailedRecipients as $recipient) {
$failedRecipients[] = $recipient;
}
$sent = 0;
}

return $sent;
}

Expand Down