[FIX] - Fix for summarization edge case #1201
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a fix for the issue mentioned in #1108
However I have a points to discuss @shahules786 :
conciseness_score
to penalize long summaries, but I also do not want to promote very very short and skimpy summaries, need to find a middle ground.averaging
a good way to combineQA_score
andconciseness_score
?Given the conclusions we reach based on these discussion points, I will push more commits, let's keep this PR open till we resolve these points.