Skip to content

Conversation

vcim
Copy link
Contributor

@vcim vcim commented Aug 26, 2024

Dict in dataset of the evaluate function specified. Does not work -> Dataset and then check of "ground_truth" in column_names.

Dict in dataset of the evaluate function specified. Does not work -> Dataset and then check of "ground_truth" in column_names.
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 26, 2024
def evaluate(
query_engine,
dataset: dict,
dataset: Dataset,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for compliance with docs

Copy link
Member

@jjmachan jjmachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the improvement 🙂

@jjmachan jjmachan merged commit 7f1073f into explodinggradients:main Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants