-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat: genetic algo based optimizer #1724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: genetic algo based optimizer #1724
Conversation
The progress bar for this now is not neat. I would like to have it as one single bar with a subprocess shown with progress. I'm not sure what the best way to do it is. |
@shahules786 check out this Lines 146 to 181 in 99d1a47
which does something similar for batching |
@jjmachan thanks, just fixed it. Please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall this works really well but I'm not sure about if we are using the executor correctly - will love to discuss this over a call before merging this in
also comments - the code is very hard to read since there are some new alogs here - proper variable names and comments will go a long way to improve the readability of the code
dummy data