Skip to content

fix: correct noncommittal detection & filter empty questions in answer_relevancy #2343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: correct noncommittal detection & filter empty questions in answer_relevancy #2343

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions src/ragas/metrics/_answer_relevance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,15 +116,21 @@ def _calculate_score(
) -> float:
question = row["user_input"]
gen_questions = [answer.question for answer in answers]
all_noncommittal = np.all([answer.noncommittal for answer in answers])
if all(q == "" for q in gen_questions):
logger.warning(
"Invalid JSON response. Expected dictionary with key 'question'"
)
score = np.nan
any_noncommittal = np.any([answer.noncommittal for answer in answers])

if any_noncommittal:
score = 0.0
else:
cosine_sim = self.calculate_similarity(question, gen_questions)
score = cosine_sim.mean() * int(not all_noncommittal)
valid_questions = [q for q in gen_questions if q.strip() != ""]

if len(valid_questions) == 0:
logger.warning(
"No valid questions generated. All questions were empty."
)
score = np.nan
else:
cosine_sim = self.calculate_similarity(question, valid_questions)
score = cosine_sim.mean()

return score

Expand Down
Loading