Skip to content

Conversation

jjmachan
Copy link
Member

@jjmachan jjmachan commented Dec 17, 2023

  1. async vs threadpool
  2. executor APIs and how to use them
  3. BaseRagasLLM - how generate_text and agenerate_text work - what is the diff
  4. change in each metric - this is the most important to get review from @ikka because there might be small bugs in calculations I missed - the code might be working now but calculation errors can be very bad

@jjmachan jjmachan marked this pull request as ready for review January 3, 2024 06:55
@jjmachan jjmachan requested a review from shahules786 January 4, 2024 14:59
@jjmachan jjmachan merged commit bad3a8e into explodinggradients:main Jan 4, 2024
@jjmachan jjmachan deleted the feat/executor branch January 4, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant