feat(metrics): skip embedding process when the corresponding weight is zero #409
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR avoids calculating the embedding when assigning an embedding weight of 0 to answer correctness
Currently, the correctness of the answer relies on both factuality and semantic similarity. However, for most embedding models, the similarity between any two embeddings will be larger than 0. This is equivalent to introducing a bias into the rating system. Therefore, in practical use, I tend to turn off similarity evaluation and only use factual evaluation.
Do you think it would be better to allow embedding to be turned off like this or to add an additional factuality metric?