Skip to content

fix(metrics): avoid dividing by zero in correctness #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 3, 2024
Merged

fix(metrics): avoid dividing by zero in correctness #421

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4f3774
fix(metrics): avoid dividing by zero
yuukidach Jan 3, 2024
951f243
update
yuukidach Jan 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/ragas/metrics/_answer_correctness.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,7 @@ def _score_batch(
prediction = (
prediction if isinstance(prediction, list) else [prediction]
)

if prediction:
prediction = [
item.get(key_map[k], np.nan)
Expand All @@ -152,7 +153,11 @@ def _score_batch(
len(item) if isinstance(item, list) else np.nan
for item in prediction
]
score = tp / (tp + 0.5 * (fp + fn))

if any([np.isnan(i) for i in [tp, fp, fn]]):
score = np.nan
else:
score = tp / (tp + 0.5 * (fp + fn)) if tp > 0 else 0
else:
score = np.nan

Expand Down