Fix ValueError: diag requires an array of at least two dimensions #474 #475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lodinggradients#474 Detailed description: - Directly use the single element as the score if the similarity array has only one item, instead of attempting to extract a diagonal. - Added a condition to check similarity.size to determine whether diagonal extraction is necessary. - Updated unit tests to reflect this change. Fixes explodinggradients#474
shahules786
requested changes
Jan 18, 2024
There was a problem hiding this comment.
Nice catch @herman159 , can you also do the same for _score function?
shahules786
approved these changes
Jan 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed description:
Fixes #474