Skip to content

fix: node indexing in testset generator #617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 17, 2024
Merged

fix: node indexing in testset generator #617

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
55064c2
ensure dict type
shahules786 Feb 9, 2024
1ae2319
Merge branch 'main' of github.com:explodinggradients/ragas
shahules786 Feb 9, 2024
8ec0b01
Merge branch 'main' of github.com:explodinggradients/ragas
shahules786 Feb 9, 2024
0c8e60c
Merge branch 'main' of github.com:explodinggradients/ragas
shahules786 Feb 12, 2024
a1d43fa
Merge branch 'main' of github.com:explodinggradients/ragas into dev#612
shahules786 Feb 16, 2024
1459df5
fix condition
shahules786 Feb 16, 2024
e44c888
fix node idx
shahules786 Feb 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/ragas/testset/evolutions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,11 @@ def merge_nodes(nodes: CurrentNodes) -> Node:
keyphrases=[phrase for n in nodes.nodes for phrase in n.keyphrases],
)

embed_dim = len(nodes.nodes[0].embedding) if nodes.nodes[0].embedding else None
embed_dim = (
len(nodes.nodes[0].embedding)
if nodes.nodes[0].embedding is not None
else None
)
if embed_dim:
node_embeddings = np.array([n.embedding for n in nodes.nodes]).reshape(
-1, embed_dim
Expand Down Expand Up @@ -444,9 +448,7 @@ async def _aevolve(
return await self.aretry_evolve(current_tries, current_nodes)
else:
assert isinstance(similar_node[0], Node), "similar_node must be a Node"
current_nodes = CurrentNodes(
root_node=merged_node, nodes=[merged_node, similar_node[0]]
)
current_nodes.nodes.append(similar_node[0])

prompt = self.multi_context_question_prompt.format(
question=simple_question,
Expand Down